[debuginfo-tests] 5c4a5da - [debuginfo-tests] Stop using installed LLDB and remove redundancy

[James Henderson via llvm-commits]

Author: James Henderson
Date: 2021-05-24T10:16:36+01:00
New Revision: 5c4a5daf293c1c924caa3c6faed4487682d70045

URL: https://github.com/llvm/llvm-project/commit/5c4a5daf293c1c924caa3c6faed4487682d70045
DIFF: https://github.com/llvm/llvm-project/commit/5c4a5daf293c1c924caa3c6faed4487682d70045.diff

LOG: [debuginfo-tests] Stop using installed LLDB and remove redundancy

The removed code just replicated what use_llvm_tool does, plus looked
for an installed LLDB on the PATH to use. In a monorepo world, it seems
likely that if people want to run the tests that require LLDB, they
should enable and build LLDB itself. If users really want to use the
installed LLDB executable, they can specify the path to the executable
as an environment variable "LLDB".

See the discussion in https://reviews.llvm.org/D95339#2638619 for
more details.

Reviewed by: jmorse, aprantl

Differential Revision: https://reviews.llvm.org/D102680

Added: 
    

Modified: 
    debuginfo-tests/lit.cfg.py

Removed: 
    


################################################################################
diff  --git a/debuginfo-tests/lit.cfg.py b/debuginfo-tests/lit.cfg.py
index 3ca6a67f02202..ac46e27d41cbf 100644
--- a/debuginfo-tests/lit.cfg.py
+++ b/debuginfo-tests/lit.cfg.py
@@ -118,12 +118,7 @@ def can_target_host():
         'debuginfo-tests project.'.format(config.host_triple))
 
 # Check which debuggers are available:
-built_lldb = llvm_config.use_llvm_tool('lldb', search_env='LLDB')
-lldb_path = None
-if built_lldb is not None:
-    lldb_path = built_lldb
-elif lit.util.which('lldb') is not None:
-    lldb_path = lit.util.which('lldb')
+lldb_path = llvm_config.use_llvm_tool('lldb', search_env='LLDB')
 
 if lldb_path is not None:
     config.available_features.add('lldb')