[PATCH] D102737: [RISCV] Add a vsetvli insert pass that can be extended to be aware of incoming VL/VTYPE from other basic blocks.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:10
+// This file implements a function pass that inserts VSETVLI instructions where
+// needed.
+//
----------------
Documenting this pass and its phases in line with the commit message would be good.


================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:18
+#include "llvm/CodeGen/MachineFunctionPass.h"
+#include <queue>
+using namespace llvm;
----------------
nit: I can imagine this is used by later patches, but it's not used by this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102737/new/

https://reviews.llvm.org/D102737