[PATCH] D102954: [AMDGPU] Lower kernel LDS into a sorted structure
Mahesha S via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 21 21:56:54 PDT 2021
hsmhsm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:228
+ Twine VarName(F ? "llvm.amdgcn.kernel." + Twine(F->getName() + ".lds")
+ : "llvm.amdgcn.module.lds");
----------------
There is some problem here - because of this, llvm -lit tests including your own newly added tests are failing.
After changing
Twine VarName(F ? "llvm.amdgcn.kernel." + Twine(F->getName() + ".lds") : "llvm.amdgcn.module.lds");
To
Twine VarName(F ? Twine("llvm.amdgcn.kernel.") + Twine(F->getName()) + Twine(".lds") : "llvm.amdgcn.module.lds");
it works.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102954/new/
https://reviews.llvm.org/D102954
More information about the llvm-commits
mailing list