[PATCH] D102884: [AMDGPU] Request module used variables from LDS lowering as internal

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

Ah, apologies. I misread/misremembered this. The global variable looked up here is llvm.used / llvm.compiler.used, and not the LDS variable that is going to be removed.

I can't tell if AppendingLinkage qualifies as internal or not from the documentation. From going code reading, it isn't. Control flow hits `AllowLocal || !Result->hasLocalLinkage()`, and appending linkage will return false for hasLocalLinkage.

I don't know if we're better off with getGlobalVariable or getNamedGlobal here. Functionally, no difference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102884/new/

https://reviews.llvm.org/D102884