[PATCH] D99080: Normalize usage of StrBoolAttr

Tue May 18 08:15:26 PDT 2021

serge-sans-paille updated this revision to Diff 346181.
serge-sans-paille added a comment.
Herald added subscribers: frasercrmck, wenlei, lxfind, okura, bbn, kuter, luismarques, apazos, sameer.abuasal, s.egerton, dmgreen, Jim, asbirlea, jocewei, rupprecht, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, steven_wu, atanasyan, edward-jones, george.burgess.iv, zzheng, MaskRay, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, javed.absar, fedor.sergeev, kbarton, aheejin, jgravelle-google, arichardson, sbc100, nemanjai, sdardis, emaste, jyknight, dschuff, qcolombet, MatzeB.
Herald added a reviewer: bollu.
Herald added a reviewer: JDevlieghere.
Herald added a reviewer: jhenderson.
Herald added a reviewer: jdoerfert.
Herald added a reviewer: sstefan1.
Herald added a reviewer: MaskRay.
Herald added a reviewer: baziotis.
Herald added a reviewer: gkm.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.

This change introduces a behavior change: when an attribute is not set, it used to mean ``use the default value''. It now means ``attribute unset''.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99080/new/

https://reviews.llvm.org/D99080

Files:
  clang/lib/CodeGen/CodeGenFunction.cpp
  clang/test/CodeGen/backend-unsupported-error.ll
  lld/test/COFF/Inputs/undefined-symbol-lto-a.ll
  lld/test/COFF/Inputs/undefined-symbol-lto-b.ll
  lld/test/COFF/Inputs/undefined-symbol-multi-lto.ll
  lld/test/MachO/mattrs.ll
  lld/test/wasm/Inputs/debuginfo1.ll
  lld/test/wasm/Inputs/debuginfo2.ll
  lld/test/wasm/debug-removed-fn.ll
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/Analysis/IVDescriptors.cpp
  llvm/lib/CodeGen/CommandFlags.cpp
  llvm/lib/CodeGen/GlobalISel/CallLowering.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/IR/Attributes.cpp
  llvm/lib/IR/AutoUpgrade.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
  llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
  llvm/lib/Target/Hexagon/HexagonTargetMachine.cpp
  llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
  llvm/lib/Target/TargetMachine.cpp
  llvm/lib/Transforms/Utils/SimplifyCFG.cpp
  llvm/test/Analysis/BranchProbabilityInfo/pr22718.ll
  llvm/test/Analysis/CostModel/SystemZ/intrinsic-cost-crash.ll
  llvm/test/Analysis/Delinearization/constant_functions_multi_dim.ll
  llvm/test/Analysis/DependenceAnalysis/MIVCheckConst.ll
  llvm/test/Analysis/DependenceAnalysis/NonCanonicalizedSubscript.ll
  llvm/test/Analysis/MemoryDependenceAnalysis/invariant.group-bug.ll
  llvm/test/Analysis/MemorySSA/pr28880.ll
  llvm/test/Analysis/MemorySSA/pr39197.ll
  llvm/test/Analysis/MemorySSA/pr40038.ll
  llvm/test/Analysis/MemorySSA/pr43569.ll
  llvm/test/Analysis/ScalarEvolution/pr22674.ll
  llvm/test/Analysis/ScalarEvolution/scev-canonical-mode.ll
  llvm/test/Analysis/TypeBasedAliasAnalysis/PR17620.ll
  llvm/test/Analysis/TypeBasedAliasAnalysis/tbaa-path.ll
  llvm/test/Bitcode/DILocation-implicit-code.ll
  llvm/test/Bitcode/drop-debug-info.3.5.ll
  llvm/test/Bitcode/upgrade-strbool-attribute.ll
  llvm/test/Bitcode/upgrade-tbaa.ll
  llvm/test/CodeGen/AArch64/GlobalISel/inline-memcpy.mir
  llvm/test/CodeGen/AArch64/GlobalISel/inline-memmove.mir
  llvm/test/CodeGen/AArch64/GlobalISel/inline-memset.mir
  llvm/test/CodeGen/AArch64/aarch64-2014-08-11-MachineCombinerCrash.ll
  llvm/test/CodeGen/AArch64/aarch64-a57-fp-load-balancing.ll
  llvm/test/CodeGen/AArch64/aarch64-dynamic-stack-layout.ll
  llvm/test/CodeGen/AArch64/aarch64-fix-cortex-a53-835769.ll
  llvm/test/CodeGen/AArch64/aarch64-mov-debug-locs.mir
  llvm/test/CodeGen/AArch64/arm64-detect-vec-redux.ll
  llvm/test/CodeGen/AArch64/arm64-fma-combine-with-fpfusion.ll
  llvm/test/CodeGen/AArch64/arm64-fp.ll
  llvm/test/CodeGen/AArch64/arm64-indexed-vector-ldst-2.ll
  llvm/test/CodeGen/AArch64/arm64-misched-basic-A53.ll
  llvm/test/CodeGen/AArch64/arm64-misched-basic-A57.ll
  llvm/test/CodeGen/AArch64/arm64-rounding.ll
  llvm/test/CodeGen/AArch64/arm64-storebytesmerge.ll
  llvm/test/CodeGen/AArch64/arm64-triv-disjoint-mem-access.ll
  llvm/test/CodeGen/AArch64/bti-branch-relaxation.ll
  llvm/test/CodeGen/AArch64/consthoist-gep.ll
  llvm/test/CodeGen/AArch64/dag-combine-invaraints.ll
  llvm/test/CodeGen/AArch64/fabs.ll
  llvm/test/CodeGen/AArch64/fcsel-zero.ll
  llvm/test/CodeGen/AArch64/fdiv-combine.ll
  llvm/test/CodeGen/AArch64/ftrunc.ll
  llvm/test/CodeGen/AArch64/illegal-float-ops.ll
  llvm/test/CodeGen/AArch64/known-never-nan.ll
  llvm/test/CodeGen/AArch64/partial-pipeline-execution.ll
  llvm/test/CodeGen/AArch64/recp-fastmath.ll
  llvm/test/CodeGen/AArch64/sched-past-vector-ldst.ll
  llvm/test/CodeGen/AArch64/sqrt-fastmath.ll
  llvm/test/CodeGen/AArch64/stack-tagging-ex-1.ll
  llvm/test/CodeGen/AArch64/stack-tagging-ex-2.ll
  llvm/test/CodeGen/AArch64/stack-tagging-untag-placement.ll
  llvm/test/CodeGen/AArch64/stack_guard_remat.ll
  llvm/test/CodeGen/AArch64/vector_merge_dep_check.ll
  llvm/test/CodeGen/AArch64/wineh-frame5.mir
  llvm/test/CodeGen/AArch64/wineh-frame6.mir
  llvm/test/CodeGen/AArch64/wineh-frame7.mir
  llvm/test/CodeGen/AArch64/wineh-frame8.mir
  llvm/test/CodeGen/AArch64/wineh5.mir
  llvm/test/CodeGen/AArch64/wineh_shrinkwrap.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/fmed3.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/frem.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/lds-relocs.ll
  llvm/test/CodeGen/AMDGPU/clamp.ll
  llvm/test/CodeGen/AMDGPU/fadd.ll
  llvm/test/CodeGen/AMDGPU/fcanonicalize-elimination.ll
  llvm/test/CodeGen/AMDGPU/fdiv.f16.ll
  llvm/test/CodeGen/AMDGPU/fdiv.f64.ll
  llvm/test/CodeGen/AMDGPU/fma-combine.ll
  llvm/test/CodeGen/AMDGPU/fmad-formation-fmul-distribute-denormal-mode.ll
  llvm/test/CodeGen/AMDGPU/fmax3.ll
  llvm/test/CodeGen/AMDGPU/fmed3.ll
  llvm/test/CodeGen/AMDGPU/fmin3.ll
  llvm/test/CodeGen/AMDGPU/fmul-2-combine-multi-use.ll
  llvm/test/CodeGen/AMDGPU/fneg-combines.ll
  llvm/test/CodeGen/AMDGPU/frem.ll
  llvm/test/CodeGen/AMDGPU/fsqrt.f64.ll
  llvm/test/CodeGen/AMDGPU/fsqrt.ll
  llvm/test/CodeGen/AMDGPU/fsub.ll
  llvm/test/CodeGen/AMDGPU/inline-attr.ll
  llvm/test/CodeGen/AMDGPU/lds-relocs.ll
  llvm/test/CodeGen/AMDGPU/llvm.amdgcn.rcp.ll
  llvm/test/CodeGen/AMDGPU/llvm.sin.ll
  llvm/test/CodeGen/AMDGPU/omod.ll
  llvm/test/CodeGen/AMDGPU/rcp-pattern.ll
  llvm/test/CodeGen/AMDGPU/v_mac.ll
  llvm/test/CodeGen/AMDGPU/v_mac_f16.ll
  llvm/test/CodeGen/ARM/2014-05-14-DwarfEHCrash.ll
  llvm/test/CodeGen/ARM/ARMLoadStoreDBG.mir
  llvm/test/CodeGen/ARM/Windows/wineh-basic.ll
  llvm/test/CodeGen/ARM/build-attributes-fn-attr2.ll
  llvm/test/CodeGen/ARM/build-attributes-fn-attr3.ll
  llvm/test/CodeGen/ARM/byval_load_align.ll
  llvm/test/CodeGen/ARM/cfguard-module-flag.ll
  llvm/test/CodeGen/ARM/clang-section.ll
  llvm/test/CodeGen/ARM/cmse-clear-float-bigend.mir
  llvm/test/CodeGen/ARM/coalesce-dbgvalue.ll
  llvm/test/CodeGen/ARM/constantpool-promote-dbg.ll
  llvm/test/CodeGen/ARM/constantpool-promote.ll
  llvm/test/CodeGen/ARM/early-cfi-sections.ll
  llvm/test/CodeGen/ARM/fp16-vld.ll
  llvm/test/CodeGen/ARM/global-merge-1.ll
  llvm/test/CodeGen/ARM/isel-v8i32-crash.ll
  llvm/test/CodeGen/ARM/loopvectorize_pr33804.ll
  llvm/test/CodeGen/ARM/out-of-registers.ll
  llvm/test/CodeGen/ARM/relax-per-target-feature.ll
  llvm/test/CodeGen/ARM/softfp-constant-comparison.ll
  llvm/test/CodeGen/ARM/stack-protector-bmovpcb_call.ll
  llvm/test/CodeGen/ARM/stack_guard_remat.ll
  llvm/test/CodeGen/ARM/struct-byval-frame-index.ll
  llvm/test/CodeGen/ARM/unschedule-first-call.ll
  llvm/test/CodeGen/ARM/urem-opt-size.ll
  llvm/test/CodeGen/ARM/vector-spilling.ll
  llvm/test/CodeGen/ARM/vldm-sched-a9.ll
  llvm/test/CodeGen/BPF/BTF/binary-format.ll
  llvm/test/CodeGen/BPF/BTF/builtin-btf-type-id-2.ll
  llvm/test/CodeGen/BPF/BTF/builtin-btf-type-id.ll
  llvm/test/CodeGen/BPF/BTF/char-no-debuginfo.ll
  llvm/test/CodeGen/BPF/BTF/extern-builtin.ll
  llvm/test/CodeGen/BPF/BTF/extern-func-arg.ll
  llvm/test/CodeGen/BPF/BTF/extern-func-ptr.ll
  llvm/test/CodeGen/BPF/BTF/extern-global-var.ll
  llvm/test/CodeGen/BPF/BTF/extern-var-func-weak-section.ll
  llvm/test/CodeGen/BPF/BTF/extern-var-func-weak.ll
  llvm/test/CodeGen/BPF/BTF/extern-var-func.ll
  llvm/test/CodeGen/BPF/BTF/extern-var-section.ll
  llvm/test/CodeGen/BPF/BTF/extern-var-struct-weak.ll
  llvm/test/CodeGen/BPF/BTF/extern-var-struct.ll
  llvm/test/CodeGen/BPF/BTF/extern-var-weak-section.ll
  llvm/test/CodeGen/BPF/BTF/filename.ll
  llvm/test/CodeGen/BPF/BTF/func-func-ptr.ll
  llvm/test/CodeGen/BPF/BTF/func-non-void.ll
  llvm/test/CodeGen/BPF/BTF/func-source.ll
  llvm/test/CodeGen/BPF/BTF/func-typedef.ll
  llvm/test/CodeGen/BPF/BTF/func-unused-arg.ll
  llvm/test/CodeGen/BPF/BTF/func-void.ll
  llvm/test/CodeGen/BPF/BTF/local-var-readonly-1.ll
  llvm/test/CodeGen/BPF/BTF/local-var-readonly-2.ll
  llvm/test/CodeGen/BPF/BTF/local-var.ll
  llvm/test/CodeGen/BPF/BTF/pruning-const.ll
  llvm/test/CodeGen/BPF/BTF/pruning-typedef.ll
  llvm/test/CodeGen/BPF/BTF/static-func.ll
  llvm/test/CodeGen/BPF/BTF/static-var-derived-type.ll
  llvm/test/CodeGen/BPF/BTF/static-var-inited-sec.ll
  llvm/test/CodeGen/BPF/BTF/static-var-inited.ll
  llvm/test/CodeGen/BPF/BTF/static-var-readonly-sec.ll
  llvm/test/CodeGen/BPF/BTF/static-var-readonly.ll
  llvm/test/CodeGen/BPF/BTF/static-var-sec.ll
  llvm/test/CodeGen/BPF/BTF/static-var-zerolen-array.ll
  llvm/test/CodeGen/BPF/BTF/static-var.ll
  llvm/test/CodeGen/BPF/BTF/struct-anon-2.ll
  llvm/test/CodeGen/BPF/BTF/weak-global-2.ll
  llvm/test/CodeGen/BPF/BTF/weak-global-3.ll
  llvm/test/CodeGen/BPF/BTF/weak-global.ll
  llvm/test/CodeGen/BPF/CORE/btf-id-duplicate.ll
  llvm/test/CodeGen/BPF/CORE/field-reloc-alu32.ll
  llvm/test/CodeGen/BPF/CORE/field-reloc-bitfield-1-bpfeb.ll
  llvm/test/CodeGen/BPF/CORE/field-reloc-bitfield-1.ll
  llvm/test/CodeGen/BPF/CORE/field-reloc-bitfield-2-bpfeb.ll
  llvm/test/CodeGen/BPF/CORE/field-reloc-bitfield-2.ll
  llvm/test/CodeGen/BPF/CORE/field-reloc-duplicate.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-array-2.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-array.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-byte-size-1.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-byte-size-2.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-byte-size-3.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-byte-size-4.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-existence-1.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-existence-2.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-existence-3.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-existence-4.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-lshift-1-bpfeb.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-lshift-1.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-lshift-2.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-rshift-1.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-rshift-2.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-rshift-3.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-signedness-1.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-signedness-2.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-fieldinfo-signedness-3.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-struct.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-typeinfo-enum-value.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-typeinfo-type-exist.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-typeinfo-type-size-1.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-typeinfo-type-size-2.ll
  llvm/test/CodeGen/BPF/CORE/intrinsic-union.ll
  llvm/test/CodeGen/BPF/CORE/no-elf-ama-symbol.ll
  llvm/test/CodeGen/BPF/CORE/no-narrow-load.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-access-str.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-basic.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-cast-array-1.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-cast-array-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-cast-struct-1.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-cast-struct-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-cast-struct-3.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-cast-union-1.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-cast-union-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-end-load.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-end-ret.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-fieldinfo-1.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-fieldinfo-2-bpfeb.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-fieldinfo-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-global-1.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-global-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-global-3.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-ignore.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-middle-chain.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-multi-array-1.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-multi-array-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-multilevel.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-pointer-1.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-pointer-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-struct-anonymous.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-struct-array.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-typedef-array.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-typedef-struct-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-typedef-struct.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-typedef-union-2.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-typedef-union.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-typedef.ll
  llvm/test/CodeGen/BPF/CORE/offset-reloc-union.ll
  llvm/test/CodeGen/BPF/CORE/store-addr.ll
  llvm/test/CodeGen/BPF/adjust-opt-icmp1.ll
  llvm/test/CodeGen/BPF/adjust-opt-icmp2.ll
  llvm/test/CodeGen/BPF/adjust-opt-speculative1.ll
  llvm/test/CodeGen/BPF/adjust-opt-speculative2.ll
  llvm/test/CodeGen/BPF/callx.ll
  llvm/test/CodeGen/BPF/dwarfdump.ll
  (758 more files...)