[PATCH] D71100: [lld][RISCV] Fixup PC-relative relocations to undefined weak symbols.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 23 19:38:25 PDT 2021
MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.
Herald added subscribers: vkmr, frasercrmck, evandro.
Request changes as the patch place is incorrect. As mentioned, the most appropriate place is `getRelocTargetVA`.
We need some guidance from psABI as well (https://github.com/riscv/riscv-elf-psabi-doc/issues/126).
I think error for branch relocation types is an incorrect behavior: https://maskray.me/blog/2021-04-25-weak-symbol
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71100/new/
https://reviews.llvm.org/D71100
More information about the llvm-commits
mailing list