[PATCH] D102926: [RISCV] Fix wrong objfile attribute bug.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 23 19:12:24 PDT 2021


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

Aside: `RTS.emitTargetAttributes(*STI);` just uses the last FeatureBits set by `setFeatureBits` (in `RISCVAsmPrinter::runOnMachineFunction`). If you have two functions with target features, the last wins.
So in practice the string is likely inferred from whatever the last `__attribute__((target(...)))`. Using the default for the rest functions seems to make more sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102926/new/

https://reviews.llvm.org/D102926



More information about the llvm-commits mailing list