[llvm] 249b40b - [AArch64] Delete unneeded fixup_aarch64_ldr_pcrel_imm19 VK_GOT special case
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Sun May 23 15:21:02 PDT 2021
Author: Fangrui Song
Date: 2021-05-23T15:20:56-07:00
New Revision: 249b40b558955afe5ac2b549edcf2d7f859c8cc9
URL: https://github.com/llvm/llvm-project/commit/249b40b558955afe5ac2b549edcf2d7f859c8cc9
DIFF: https://github.com/llvm/llvm-project/commit/249b40b558955afe5ac2b549edcf2d7f859c8cc9.diff
LOG: [AArch64] Delete unneeded fixup_aarch64_ldr_pcrel_imm19 VK_GOT special case
An AArch64 VK_GOT fixup must have a symbol. MCAssembler::evaluateFixup considers
such a fixup not resolved. The code path cannot trigger.
Added:
Modified:
llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp
index 02570e864e40..290fe88a8cec 100644
--- a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp
+++ b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp
@@ -491,13 +491,6 @@ bool AArch64AsmBackend::shouldForceRelocation(const MCAssembler &Asm,
if (Kind == AArch64::fixup_aarch64_pcrel_adrp_imm21)
return true;
- AArch64MCExpr::VariantKind RefKind =
- static_cast<AArch64MCExpr::VariantKind>(Target.getRefKind());
- AArch64MCExpr::VariantKind SymLoc = AArch64MCExpr::getSymbolLoc(RefKind);
- // LDR GOT relocations need a relocation
- if (Kind == AArch64::fixup_aarch64_ldr_pcrel_imm19 &&
- SymLoc == AArch64MCExpr::VK_GOT)
- return true;
return false;
}
More information about the llvm-commits
mailing list