[PATCH] D102985: [lld][ELF][SPARC] Fix GOT-relative relocations

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In D102985#2776031 <https://reviews.llvm.org/D102985#2776031>, @LemonBoy wrote:

> In D102985#2776028 <https://reviews.llvm.org/D102985#2776028>, @MaskRay wrote:
>
>> I dislike that we are fixing these stuff increasingly with so many patches.
>>
>> See the history of Arch/PPC.cpp - most stuff are implemented with very few commits.
>
> I'm getting a bit tired of splitting and merging patches, can we please decide on what the best course of action is and end this suffering?

Hm, MaskRay makes a good point. I guess my real complaint when I stop and think about it is not combining multiple things into one commit, but having a commit that says "do X" when it's really "do X and Y". One commit that's "fix everything", or two commits "fix everything except TLS" and "finish TLS", seems fine to me, so long as the descriptions are correct and don't sneak in changes that are unrelated to the commit _message_.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102985/new/

https://reviews.llvm.org/D102985