[PATCH] D102575: [SPARC][MC] Support more relocation types

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 23 08:24:39 PDT 2021


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:57
 
+  enum class TailRelocKind { Load, Add_TLS, Load_TLS, Call_TLS };
+
----------------
Load isn't a great name given there's Load_TLS. Should say GOT or similar in it.


================
Comment at: llvm/lib/Target/Sparc/AsmParser/SparcAsmParser.cpp:1531
 
+  default: break;
+  }
----------------
This should be followed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102575/new/

https://reviews.llvm.org/D102575



More information about the llvm-commits mailing list