[PATCH] D102972: [lld-macho][nfc] Sort OutputSections based on explicit order of command-line inputs
    Alexander Shaposhnikov via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sat May 22 19:32:33 PDT 2021
    
    
  
alexshap added inline comments.
================
Comment at: lld/MachO/OutputSegment.h:47
       llvm::function_ref<bool(OutputSection *, OutputSection *)> comparator) {
-    llvm::stable_sort(sections, comparator);
+    llvm::sort(sections, comparator);
   }
----------------
the presence of `comparator` and `inputOrder`, perhaps, deserves some comments
(e.g. are there any places where sections are sorted using different comparators ?)
otherwise this probably can be simplified a bit.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102972/new/
https://reviews.llvm.org/D102972
    
    
More information about the llvm-commits
mailing list