[PATCH] D53234: Don't remove COMDATs when internalizing global objects

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 22 16:03:20 PDT 2021


MaskRay added inline comments.


================
Comment at: test/Transforms/Internalize/preserve-comdat-members.ll:9
+; CHECK: @used_global = internal global i32 0, comdat($c1), !associated !0
+ at used_global = global i32 0, comdat($c1), !associated !0
+
----------------
The test case should be changed to use two functions in the same group, instead of using `!associated`.

The `!associated` use case is a weak justification.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53234/new/

https://reviews.llvm.org/D53234



More information about the llvm-commits mailing list