[llvm] 4272fca - [ORC] Check for underflow on SymbolStringPtr ref-counts.

[Lang Hames via llvm-commits]

Author: Lang Hames
Date: 2021-05-21T21:11:54-07:00
New Revision: 4272fca2db9c27ab836082f796d281e5e68b0638

URL: https://github.com/llvm/llvm-project/commit/4272fca2db9c27ab836082f796d281e5e68b0638
DIFF: https://github.com/llvm/llvm-project/commit/4272fca2db9c27ab836082f796d281e5e68b0638.diff

LOG: [ORC] Check for underflow on SymbolStringPtr ref-counts.

Added: 
    

Modified: 
    llvm/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h b/llvm/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h
index c9fadd727e887..63abb196ba491 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/SymbolStringPool.h
@@ -62,8 +62,10 @@ class SymbolStringPtr {
   }
 
   SymbolStringPtr& operator=(const SymbolStringPtr &Other) {
-    if (isRealPoolEntry(S))
+    if (isRealPoolEntry(S)) {
+      assert(S->getValue() && "Releasing SymbolStringPtr with zero ref count");
       --S->getValue();
+    }
     S = Other.S;
     if (isRealPoolEntry(S))
       ++S->getValue();
@@ -75,16 +77,20 @@ class SymbolStringPtr {
   }
 
   SymbolStringPtr& operator=(SymbolStringPtr &&Other) {
-    if (isRealPoolEntry(S))
+    if (isRealPoolEntry(S)) {
+      assert(S->getValue() && "Releasing SymbolStringPtr with zero ref count");
       --S->getValue();
+    }
     S = nullptr;
     std::swap(S, Other.S);
     return *this;
   }
 
   ~SymbolStringPtr() {
-    if (isRealPoolEntry(S))
+    if (isRealPoolEntry(S)) {
+      assert(S->getValue() && "Releasing SymbolStringPtr with zero ref count");
       --S->getValue();
+    }
   }
 
   explicit operator bool() const { return S; }