[PATCH] D102315: [llvm-dwp] Adding support for v5 index writing

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks OK - though honestly lots of this code (that I wrote) could use a bunch of refactoring, comments, smaller/more self-documenting functions, etc.



================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:703-704
 
+    std::vector<std::pair<DWARFSectionKind, uint32_t>> SectionLength;
+
     for (const auto &Section : Obj.sections())
----------------
A comment describing what this does would be handy


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102315/new/

https://reviews.llvm.org/D102315