[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 19:39:10 PDT 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D100630#2775207 <https://reviews.llvm.org/D100630#2775207>, @aprantl wrote:

> If gracefully lowering rvalue references to references needs knowledge about the Clang typesystem (or depends on LLVM IR type uniquing to be efficient, as @dblaikie points out) then we should do it in the Clang frontend. As much as we can we should avoid encoding debug info format specific knowledge in the Clang frontend, but that's not always possible. I'm fine with taking this patch.

Fair enough then - thanks for chiming in!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100630/new/

https://reviews.llvm.org/D100630



More information about the llvm-commits mailing list