[PATCH] D102588: [UpdateTestChecks] Default --x86_scrub_rip to False

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 19:21:15 PDT 2021


MaskRay added a comment.

In D102588#2775180 <https://reviews.llvm.org/D102588#2775180>, @pengfei wrote:

> In D102588#2774515 <https://reviews.llvm.org/D102588#2774515>, @MaskRay wrote:
>
>> In D102588#2772686 <https://reviews.llvm.org/D102588#2772686>, @pengfei wrote:
>>
>>>> Updated LCPI regex to include Darwin style LCPI_[0-9]+_[0-9]+ (no
>>>> leading dot).
>>>
>>> Do we have a test for it?
>>
>> llvm/test/CodeGen/X86/WidenArith.ll
>
> It seems it still has leading dot. Anyway, just nitpick.

See `llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-constant-pool.ll.expected`. Darwin's temporary symbols start with `L` instead of `.L`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102588/new/

https://reviews.llvm.org/D102588



More information about the llvm-commits mailing list