[PATCH] D102950: [LegalizeTypes] Avoid promotion of exponent in FPOWI

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 15:48:41 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1990
 SDValue DAGTypeLegalizer::PromoteIntOp_FPOWI(SDNode *N) {
-  SDValue Op = SExtPromotedInteger(N->getOperand(1));
-  return SDValue(DAG.UpdateNodeOperands(N, N->getOperand(0), Op), 0);
+  // The integer operand is the last operand in FPOWI (so the result and
+  // floating point operand is already type legalized).
----------------
Can you add an assert that N->getOpcode() is FPOWI and add a FIXME that we need to support STRICT_FPOWI? RISCV doesn't support strict FP yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102950/new/

https://reviews.llvm.org/D102950



More information about the llvm-commits mailing list