[PATCH] D102934: [unroll] Use value domain for symbolic execution based cost model

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I think it would be good to split this into two parts: One that changes the infrastructure to map to Value rather than Constant, making use of the existing SimplifyBinOp fold. And another that replaces constant folding with InstSimplify calls in the places it's not used yet.



================
Comment at: llvm/lib/Analysis/LoopUnrollAnalyzer.cpp:203
     }
   }
 
----------------
With the added SimplifyCmpInst, I'd expect that we no longer need this `ConstantExpr::getCompare()` block.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102934/new/

https://reviews.llvm.org/D102934