[PATCH] D102937: [lld][WebAssembly] Fix for PIC output + TLS + non-shared-memory

Fri May 21 14:17:53 PDT 2021

sbc100 added inline comments.

================
Comment at: lld/test/wasm/data-segments.ll:123
 ; PASSIVE64-PIC-NEXT:          - Type:            I64
 ; PASSIVE-PIC-NEXT:            Count:           1
+; PASSIVE32-PIC-NEXT:        Body:            230141B4CE006A2100200041004101FE480200044020004101427FFE0102001A05410023016A4100410DFC080000411023016A41004114FC08010020004102FE1702002000417FFE0002001A0BFC0900FC09010B
----------------
dschuff wrote:
> are these just data and rodata sections then?
Yes, with passive (shared memory) segments we no longer combine them so they are separate. (as they would be for normal non-PIC code).

Added more checks below regarding the actual data.

================
Comment at: lld/test/wasm/tls-non-shared-memory.s:102
+# PIC-NEXT:          Index:           0
+# PIC-NEXT:        Content:         2B0000002A000000
----------------
dschuff wrote:
> I guess checking the content will ensure that the segments are merged. Does it also make sense to check that there are no additional segments?
I think this matches the above tests that checks for the two separate segments.    I added a CHECK-NEXT to both of them to make sure there are no subsequent segments.  I also added a comment here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102937/new/

https://reviews.llvm.org/D102937