[PATCH] D102726: [IR][AutoUpgrade] Drop alignment from non-pointer parameters and returns

Fri May 21 14:04:57 PDT 2021

jdoerfert added a comment.

In D102726#2774657 <https://reviews.llvm.org/D102726#2774657>, @nikic wrote:

> FYI, this change causes a non-trivial compile-time regression in LTO builds: https://llvm-compile-time-tracker.com/compare.php?from=136ced498ba84f6b6126051626e319f18ba740f5&to=5b6cae5524905bc43cfc21a515f828528d1f2e68&stat=instructions (Worst regression seems to be the ThinLTO kc.link step, which is up 4%.)
>
> LLVM attributes are optimized for immutable usage, and it's hard to overstate just how slow the mutable APIs on them are...

I suggested not to check for attributes just to remove them. I still think that's the right thing *but* we can check for them in the remove functions.
@nikic you think that will resolve the compile time issue?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102726/new/

https://reviews.llvm.org/D102726