[PATCH] D102937: [lld][WebAssembly] Fix for PIC output + TLS + non-shared-memory
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 21 13:58:37 PDT 2021
dschuff added a comment.
Ah, got it. So is it the case that we have e.g. a single `.tdata` section that might be separate now, but just 1 or 2 and not scaling with the size of the program.
Mostly I just want to make sure we don't slow down loading too much, especially in the dylib case where it will already be slower than the non-library case.
================
Comment at: lld/test/wasm/data-segments.ll:123
; PASSIVE64-PIC-NEXT: - Type: I64
; PASSIVE-PIC-NEXT: Count: 1
+; PASSIVE32-PIC-NEXT: Body: 230141B4CE006A2100200041004101FE480200044020004101427FFE0102001A05410023016A4100410DFC080000411023016A41004114FC08010020004102FE1702002000417FFE0002001A0BFC0900FC09010B
----------------
are these just data and rodata sections then?
================
Comment at: lld/test/wasm/tls-non-shared-memory.s:102
+# PIC-NEXT: Index: 0
+# PIC-NEXT: Content: 2B0000002A000000
----------------
I guess checking the content will ensure that the segments are merged. Does it also make sense to check that there are no additional segments?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102937/new/
https://reviews.llvm.org/D102937
More information about the llvm-commits
mailing list