[PATCH] D102796: [SCEV] Cache operands used in BEInfo
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 21 13:46:11 PDT 2021
nikic added a comment.
In D102796#2774198 <https://reviews.llvm.org/D102796#2774198>, @lebedev.ri wrote:
> This is great.
> I, however, wonder if we are missing some more global caching for the `ScalarEvolution::isSCEVExprNeverPoison(const Instruction *)` itself.
> For example, can we simply cache the entire result of that function?
> When would it need to be invalidated?
I don't think these things are related: This is addressing a problem where the process of invalidation itself is expensive, while performance issues in isSCEVExprNeverPoison() would appear either during initial SCEV construction or //after// invalidation. Caching isSCEVExprNeverPoison() results shouldn't have an impact on the performance of invalidation itself.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102796/new/
https://reviews.llvm.org/D102796
More information about the llvm-commits
mailing list