[compiler-rt] 1c6272a - [scudo] Try to re-enabled the test on arm
Vitaly Buka via llvm-commits
llvm-commits at lists.llvm.org
Fri May 21 10:57:58 PDT 2021
Author: Vitaly Buka
Date: 2021-05-21T10:57:49-07:00
New Revision: 1c6272a481fda287f9b506a83ed21d74131742af
URL: https://github.com/llvm/llvm-project/commit/1c6272a481fda287f9b506a83ed21d74131742af
DIFF: https://github.com/llvm/llvm-project/commit/1c6272a481fda287f9b506a83ed21d74131742af.diff
LOG: [scudo] Try to re-enabled the test on arm
It's probably fixed by D102886.
Builder to watch https://lab.llvm.org/buildbot/#/builders/clang-cmake-armv7-full
Reviewed By: hctim, cryptoad
Differential Revision: https://reviews.llvm.org/D102887
Added:
Modified:
compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp
Removed:
################################################################################
diff --git a/compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp b/compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp
index 608dfd8bc73f..c50101a6d535 100644
--- a/compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp
+++ b/compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp
@@ -33,11 +33,6 @@ template <typename Config> static void testSecondaryBasic(void) {
EXPECT_GE(SecondaryT::getBlockSize(P), Size);
L->deallocate(scudo::Options{}, P);
-// TODO(hctim): Looks like the secondary pointer doesn't get unmapped on arm32.
-// It's not clear whether this is a kernel issue, or something in EXPECT_DEATH()
-// is mmap-ing something that uses the same vaddr space. For now, just disable
-// the test on arm32 until we can debug it further.
-#ifndef __arm__
// If the Secondary can't cache that pointer, it will be unmapped.
if (!L->canCache(Size)) {
EXPECT_DEATH(
@@ -52,7 +47,6 @@ template <typename Config> static void testSecondaryBasic(void) {
},
"");
}
-#endif // __arm__
const scudo::uptr Align = 1U << 16;
P = L->allocate(scudo::Options{}, Size + Align, Align);
More information about the llvm-commits
mailing list