[PATCH] D102463: Making Instrumentation aware of LoopNest Pass

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:188
+private:
+  const Loop &getLoopFromIR(Loop &L) { return L; }
+  const Loop &getLoopFromIR(LoopNest &LN) { return LN.getOutermostLoop(); }
----------------
these probably make more sense as static functions, but not a huge deal


================
Comment at: llvm/test/Other/loopnest-callback.ll:1
+;RUN: opt -disable-output -loop-interchange \
+;RUN:      -print-after=loop-interchange < %s 2>&1 |\
----------------
`-passes=loop-interchange`


================
Comment at: llvm/test/Other/loopnest-callback.ll:2
+;RUN: opt -disable-output -loop-interchange \
+;RUN:      -print-after=loop-interchange < %s 2>&1 |\
+;RUN:      FileCheck --check-prefix=CHECK %s
----------------
`--print-after-all`, `--print-after` isn't super well supported in the new PM due to pass naming being weird


================
Comment at: llvm/test/Other/loopnest-callback.ll:3
+;RUN:      -print-after=loop-interchange < %s 2>&1 |\
+;RUN:      FileCheck --check-prefix=CHECK %s
+
----------------
this is already the default, just `FileCheck %s` works


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102463/new/

https://reviews.llvm.org/D102463