[PATCH] D102891: [llvm-reduce] Exit when input module is malformed

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 10:35:54 PDT 2021


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

lgtm with the test CHECK change



================
Comment at: llvm/test/tools/llvm-reduce/fail-file-open.test:5
+
+# CHECK: llvm-reduce: {{.*}}.NotAFileInTestingDir: error: Could not open input file: No such file or directory
----------------
is this error message cross platform? for example, I see
```
# Don't check the OS-dependent message "No such file or directory".
```
in llvm/test/tools/llvm-objdump/invalid-input.test

I think everything up to the `error:` is good enough. The main thing is that it doesn't crash.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102891/new/

https://reviews.llvm.org/D102891



More information about the llvm-commits mailing list