[PATCH] D102918: [RISCV] Avoid undef result due to promotion of FPOWI exponent

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 09:42:24 PDT 2021


efriedma added a comment.

I don't think this is the right approach... in particular, messing with target-specific code means that every target that doesn't have 32-bit registers would need to explicitly handle this.

What we should be doing is changing DAGTypeLegalizer::PromoteIntOp_FPOWI so it doesn't generate an FPOWI with a 64-bit operand, so we don't have an issue in the first place.  We can generate the powi libcall from there, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102918/new/

https://reviews.llvm.org/D102918



More information about the llvm-commits mailing list