[PATCH] D102496: [Passes] Run vector-combine early with -fenable-matrix.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 09:28:27 PDT 2021


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In D102496#2773930 <https://reviews.llvm.org/D102496#2773930>, @fhahn wrote:

> In D102496#2772019 <https://reviews.llvm.org/D102496#2772019>, @spatel wrote:
>
>> Over in D102002 <https://reviews.llvm.org/D102002>, I am looking at divergence between the regular and LTO pipelines...
>> If I'm seeing this correctly, we will not alter the LTO pipeline in this patch. Is that intentional?
>
> Yes that's intentional. The motivation to run `vector-combine` early here is to catch combine & scalarization opportunities before operations are moved too much by GVN, unrolling & co. At the LTO stage, those should already be covered by the pre-LTO steps, so there's no need to do another run during the LTO stage I think.

Ah, I still haven't made sense of all the pipeline stages for LTO. 
LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102496/new/

https://reviews.llvm.org/D102496



More information about the llvm-commits mailing list