[PATCH] D94597: [X86] Lower calls with clang.arc.attachedcall bundle

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks Ahmed! I'll address your comment and then I'll land it. I expect that we will probably be making a couple of improvements once this lands and gets wider test coverage



================
Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:244
+  auto *I8PtrTy = PointerType::get(IntegerType::get(Context, 8), 0);
+  FunctionCallee FCache = M->getOrInsertFunction(
+      RuntimeCallType == 0 ? "objc_retainAutoreleasedReturnValue"
----------------
ab wrote:
> why "Cache"?
I'm not sure any more, I'll rename it to `Fn` :)


================
Comment at: llvm/test/CodeGen/X86/call-rv-marker.ll:161
 
+; TODO: This should use "callq *_fptr(%rip)".
 define i8* @rv_marker_5_indirect_call() {
----------------
ab wrote:
> Hmm, I'm curious, do you know why this doesn't trigger?  Is it just missing entries in the fold tables?  (does the extra operand make that trickier than it should be?)
Yes I think there's an entry missing to optimize this. I'll investigate that separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94597/new/

https://reviews.llvm.org/D94597