[PATCH] D102888: [PDB] Enable parallel ghash type merging by default

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 08:21:08 PDT 2021


rnk added a comment.

In D102888#2773545 <https://reviews.llvm.org/D102888#2773545>, @aganea wrote:

> @rnk as a next step, you would probably want to re-do D43881 <https://reviews.llvm.org/D43881> so that `-gcodeview-ghash` is enabled by default when building LLVM?

Oh right, I guess I switched to gn on Windows since then. You can see I did the equivalent here:

  $ git grep -B1 gcodeview-ghash llvm
  llvm/utils/gn/build/BUILD.gn-      if (use_lld && is_clang) {
  llvm/utils/gn/build/BUILD.gn:        cflags += [ "-gcodeview-ghash" ]

I think at the time that I was using cmake, I just kept adding -gcodeview-ghash to CMAKE_CXX_FLAGS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102888/new/

https://reviews.llvm.org/D102888



More information about the llvm-commits mailing list