[PATCH] D102212: [AMDGPU] Add Optimize VGPR LiveRange Pass.

[Ruiling, Song via Phabricator via llvm-commits]

ruiling added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp:199
+        MachineOperand &MO = MI.getOperand(Op);
+        if (!MO.isReg() || MO.getReg() == 0 || MO.isDef())
+          continue;
----------------
critson wrote:
> What is the "MO.getReg() == 0" for? It does not seem correct.
they are just for trivial invalid case,  should be AMDGPU::NoRegister, why not correct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102212/new/

https://reviews.llvm.org/D102212