[PATCH] D102679: [llvm] Make Sequence reverse-iterable

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 06:22:51 PDT 2021


gchatelet added inline comments.


================
Comment at: llvm/include/llvm/ADT/Sequence.h:146
+template <typename ValueT> struct value_range {
+  using value_type = const ValueT;
+  using reference = ValueT &;
----------------
courbet wrote:
> why const ? This makes `value_range` not movable.
Indeed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102679/new/

https://reviews.llvm.org/D102679



More information about the llvm-commits mailing list