[PATCH] D100944: [MC][ELF] Emit separate unique sections for different flags

Tomas Matheson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 02:53:40 PDT 2021


tmatheson updated this revision to Diff 346968.
tmatheson marked an inline comment as done.
tmatheson added a comment.

Thanks everyone for the comments.

- RTDyldObjectLinkingLayerTest: fixed assert strings and added clarifying comments.
- changed CHECK-LABEL -> CHECK in both tests
- Confirmed this works with -function-sections and added a RUN line and an extra function to the test. `.text` is still emitted, and the relevant functions are placed in `.section .text.XXXX` without `unique`.
- Clarified some comments as suggested


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100944/new/

https://reviews.llvm.org/D100944

Files:
  llvm/include/llvm/MC/MCContext.h
  llvm/lib/MC/MCContext.cpp
  llvm/test/CodeGen/Generic/elf-unique-sections-by-flags.ll
  llvm/test/CodeGen/Mips/gpopt-explict-section.ll
  llvm/test/CodeGen/X86/explicit-section-mergeable.ll
  llvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100944.346968.patch
Type: text/x-patch
Size: 25120 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210521/216c5372/attachment.bin>


More information about the llvm-commits mailing list