[PATCH] D102829: Add --quiet option to llvm-gsymutil to suppress output of warnings.

Simon Giesecke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 21 01:54:09 PDT 2021


simon.giesecke added a comment.

In D102829#2771754 <https://reviews.llvm.org/D102829#2771754>, @clayborg wrote:

> Contents looks good, just need a test to ensure that warnings are quieted. There should  be a test for each kind of warning, so it should be easy to run that same command with the --quiet option and verify that the warning does _not_ appear.

Makes sense. However, I didn't find any tests for these warnings in llvm/test/tools/llvm-gsymutil.

There are test cases in https://github.com/llvm/llvm-project/blob/1d01fc100bb5bef5f5eaf92520b2e52f64ee1d6e/llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp, however they don't check the warnings either. It seems that a test case like `TestDWARFTextRanges` would trigger a warning, though I am not completely sure which one. Should these test cases be transferred into llvm-lit tests as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102829/new/

https://reviews.llvm.org/D102829



More information about the llvm-commits mailing list