[PATCH] D93838: [SCCP] Add Function Specialization pass
Chuanqi Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 21 00:08:14 PDT 2021
ChuanqiXu added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/FunctionSpecialization.cpp:315-317
+ uint64_t Cost =
+ TTI.getUserCost(U, TargetTransformInfo::TCK_SizeAndLatency) ==
+ TargetTransformInfo::TCC_Free;
----------------
Should this be `!=` instead? Or I think we should use `TTI.getUserCost` for the initial value directly. Now if `getUserCost` returns non-zero, the value for Cost would become 0! It is too weird.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93838/new/
https://reviews.llvm.org/D93838
More information about the llvm-commits
mailing list