[PATCH] D102694: [lit][gtest] Support SKIPPED tests

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/utils/lit/lit/formats/googletest.py:138
 
+        if '[  SKIPPED ] 1 test,' in out:
+            return lit.Test.SKIPPED, ''
----------------
delcypher wrote:
> Looking for this exact string seems fragile. Maybe use a regex that can cope with a variable amount of spaces?
This corresponds to how the framework prints the summary, see `PrettyUnitTestResultPrinter::OnTestIterationEnd()`. If that is broken in some future release of the framework, we will fix the condition, but before that, we cannot predict in which way the report may be changed, so there is no need to overcomplicate the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102694/new/

https://reviews.llvm.org/D102694