[PATCH] D100672: [ADT] Add new type traits for type pack indexes

Thu May 20 14:06:31 PDT 2021

scott.linder added a comment.

In D100672#2769781 <https://reviews.llvm.org/D100672#2769781>, @stella.stamenova wrote:

>> I'm not sure what to make of it now, and I'm not particularly familiar with Windows or MSVC. I'm still amenable to changing the code, but I also fear the changes I made won't actually fix the issue as I am only testing on godbolt. Is there any shortcut to testing with the Windows buildbots? Or do I have to install Windows somewhere and try to reproduce it?
>
> There is no way to test on the official buildbots, you'd have to install Windows. If you have a change that's ready to test, I could run it locally for you.

Yes, if you could test a change for me I would greatly appreciate it! It would save me a lot of headache

The current diff of this review is what I believe should work on any version of MSVC with /std:c++14

Could you run test the current diff and let me know the results? Thank you!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100672/new/

https://reviews.llvm.org/D100672