[PATCH] D102726: [IR][AutoUpgrade] Drop alignment from non-pointer parameters and returns

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D102726#2769856 <https://reviews.llvm.org/D102726#2769856>, @steven_wu wrote:

> In D102726#2769821 <https://reviews.llvm.org/D102726#2769821>, @dexonsmith wrote:
>
>> Can you include the revert to attributes-3.3.ll.bc as part of this?
>
> I don't think that matters too much

I think it matters. With the original file in place, it's clear that we actually upgrade correctly all the attributes that were in the 3.3 test. Without it, it's unclear.

> I am not sure if I revert a binary file will add a duplication to git history.

Every object in Git is referenced by the hash of its content. Older commits (before @jdoerfert's patch) will point at the same hash for attributes-3.3.ll.bc as the new commits after it gets reverted back. There's no duplication here.

> The case in 3.3 version is kind of covered by newly added test case except created by different llvm version.

Yeah, kind of. But not entirely.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102726/new/

https://reviews.llvm.org/D102726