[llvm] e1ffcfc - [gn build] try reverting code part of f05fbb7795

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Thu May 20 12:10:26 PDT 2021


Author: Nico Weber
Date: 2021-05-20T15:08:39-04:00
New Revision: e1ffcfcee7695b8b96d5d1fad4174b4bd4fd341e

URL: https://github.com/llvm/llvm-project/commit/e1ffcfcee7695b8b96d5d1fad4174b4bd4fd341e
DIFF: https://github.com/llvm/llvm-project/commit/e1ffcfcee7695b8b96d5d1fad4174b4bd4fd341e.diff

LOG: [gn build] try reverting code part of f05fbb7795

Maybe aa8fe8fe6c7b was all that was needed to fix the build and
we can keep the code with fewer conditionals after all.

Added: 
    

Modified: 
    llvm/utils/gn/build/symbol_exports.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/gn/build/symbol_exports.py b/llvm/utils/gn/build/symbol_exports.py
index 7f5a4e9ca39a..198eb057ccc0 100755
--- a/llvm/utils/gn/build/symbol_exports.py
+++ b/llvm/utils/gn/build/symbol_exports.py
@@ -25,12 +25,12 @@ def main():
     symbols = open(args.source).readlines()
 
     if args.format == 'linux':
-        output_lines = ['FOO {\n']
-        if symbols:
-            output_lines += (['  global:\n',] +
-                             ['    %s;\n' % s.rstrip() for s in symbols])
-        output_lines += ['  local: *;\n',
-                         '};\n']
+        output_lines = (['FOO {\n',
+                         '  global:\n',] +
+                        ['    %s;\n' % s.rstrip() for s in symbols] +
+                        ['  local:\n',
+                         '    *;\n',
+                         '};\n'])
     elif args.format == 'mac':
         output_lines = ['_' + s for s in symbols]
     else:


        


More information about the llvm-commits mailing list