[PATCH] D101569: [LLD] [COFF] Fix automatic export of symbols from LTO objects

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 20 12:09:42 PDT 2021


mstorsjo added inline comments.


================
Comment at: lld/COFF/InputFiles.cpp:1050
+  FakeSection(int c) { section.Characteristics = c; }
+  const coff_section *operator&() const { return §ion; }
+
----------------
rnk wrote:
> Wouldn't it be simpler to make the field public, and take the address of the field in the constructor below?
I guess that would work just as well, and be clearer. Will change before pushing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101569/new/

https://reviews.llvm.org/D101569



More information about the llvm-commits mailing list