[PATCH] D102472: [HWASAN] Update the tag info for X86_64

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 20 11:41:41 PDT 2021


morehouse added a comment.

Hi Xiang, thanks for the patch.

I haven't looked too close yet, but a couple questions:

1. There seems to be multiple things going on in this patch:  adding stack support on x86, adding a (debug?) flag `ClUntagPointer`, adding x86_64 assembly to the runtime.  Could you break this up into smaller separate patches for independent review?
2. How are you testing the patch?  I am currently setting up a QEMU+LAM buildbot for CI, and I would prefer if we waited to land any more LAM stuff until the buildbot is setup to ensure things don't break.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102472/new/

https://reviews.llvm.org/D102472



More information about the llvm-commits mailing list