[PATCH] D86812: [DebugInstrRef][1/3] Track PHI values through register allocation

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 20 07:24:20 PDT 2021


jmorse updated this revision to Diff 346720.
jmorse added a comment.

Ping and update for @djtodoro 's comments -- some minor editing and deleting of un-necessary parts of tests.

Now that I'm confident that the overall approach is sound (see D102158 <https://reviews.llvm.org/D102158>), I'd like to put this patch series back into peoples minds again.

Promoting from inline:

> Do we need the std::map sortness? Can we use llvm::DenseMap instead?

No, and I've removed it in this revision. I've been pursuing a "don't prematurely optimise" approach during development, but it makes sense to optimise when actually committing things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86812/new/

https://reviews.llvm.org/D86812

Files:
  llvm/include/llvm/CodeGen/MachineFunction.h
  llvm/include/llvm/CodeGen/MachineInstr.h
  llvm/include/llvm/Support/TargetOpcodes.def
  llvm/include/llvm/Target/Target.td
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/LiveDebugVariables.cpp
  llvm/lib/CodeGen/PHIElimination.cpp
  llvm/lib/CodeGen/PrologEpilogInserter.cpp
  llvm/test/DebugInfo/MIR/InstrRef/phi-regallocd-to-stack.mir
  llvm/test/DebugInfo/MIR/InstrRef/phi-through-regalloc.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86812.346720.patch
Type: text/x-patch
Size: 25008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210520/5d1fa73d/attachment-0001.bin>


More information about the llvm-commits mailing list