[PATCH] D102841: [NFC][Debugify][Original DI] Use MapVector insted of DenseMap for DI tracking

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 20 05:01:46 PDT 2021


djtodoro created this revision.
djtodoro added a reviewer: jmorse.
djtodoro added projects: debug-info, LLVM.
djtodoro requested review of this revision.
Herald added a subscriber: llvm-commits.

By using MapVector instead of DenseMap, reporting issues will be in deterministic order.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102841

Files:
  llvm/include/llvm/Transforms/Utils/Debugify.h


Index: llvm/include/llvm/Transforms/Utils/Debugify.h
===================================================================
--- llvm/include/llvm/Transforms/Utils/Debugify.h
+++ llvm/include/llvm/Transforms/Utils/Debugify.h
@@ -14,7 +14,6 @@
 #ifndef LLVM_TRANSFORMS_UTILS_DEBUGIFY_H
 #define LLVM_TRANSFORMS_UTILS_DEBUGIFY_H
 
-#include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/MapVector.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/Bitcode/BitcodeWriterPass.h"
@@ -23,11 +22,11 @@
 #include "llvm/IR/PassManager.h"
 #include "llvm/IR/ValueHandle.h"
 
-using DebugFnMap = llvm::DenseMap<llvm::StringRef, const llvm::DISubprogram *>;
-using DebugInstMap = llvm::DenseMap<const llvm::Instruction *, bool>;
-using DebugVarMap = llvm::DenseMap<const llvm::DILocalVariable *, unsigned>;
+using DebugFnMap = llvm::MapVector<llvm::StringRef, const llvm::DISubprogram *>;
+using DebugInstMap = llvm::MapVector<const llvm::Instruction *, bool>;
+using DebugVarMap = llvm::MapVector<const llvm::DILocalVariable *, unsigned>;
 using WeakInstValueMap =
-    llvm::DenseMap<const llvm::Instruction *, llvm::WeakVH>;
+    llvm::MapVector<const llvm::Instruction *, llvm::WeakVH>;
 
 /// Used to track the Debug Info Metadata information.
 struct DebugInfoPerPass {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102841.346701.patch
Type: text/x-patch
Size: 1257 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210520/e2e757f8/attachment.bin>


More information about the llvm-commits mailing list