[PATCH] D102825: [llvm-strip] Add support for '--' for delimiting options from input files

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/dash-dash.test:13-14
+# RUN: cp -- test-obj strip-obj1
+# RUN: llvm-strip --remove-section=.test strip-obj1 -- --strip-symbol
+# RUN: cmp -- strip-obj1 --strip-symbol
+
----------------
I think this needs to be as suggested in the edit. This will ensure that the files have actually been stripped too.


================
Comment at: llvm/test/tools/llvm-objcopy/dash-dash.test:23-24
+# RUN: cp -- test-obj strip-obj2
+# RUN: llvm-strip -- strip-obj2 --keep-symbol
+# RUN: cmp -- strip-obj2 --keep-symbol
+
----------------
Similar to above, do a run without the dash dash, and compare the modified file against one of these two files too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102825/new/

https://reviews.llvm.org/D102825