[PATCH] D102825: [llvm-strip] Add support for '--' for delimiting options from input files

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/dash-dash.test:12
+# RUN: cp -- test-obj --strip-symbol
+# RUN: llvm-strip --remove-section=.test -- --strip-symbol
+# RUN: cp -- test-obj strip-obj1
----------------
I think you should have two inputs here, much like llvm-objcopy has two positional arguments. Same goes below. In other words, test the same set of positional arguments as llvm-objcopy does (it's just that in llvm-strip's case, they are both inputs, not one input and one output).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102825/new/

https://reviews.llvm.org/D102825