[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

Thu May 20 00:34:11 PDT 2021

jhenderson added inline comments.

================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:96-97
+            object_error::parse_failed,
+            "continued " + recordType(RecordType) +
+                " record is not followed by a continuation record");
+        return;
----------------
Is there an index/ID/offset you could use in these messages? It will help users find the invalid record (since it may not be easy to identify which record has the specified type, if things are broken). Take a look at how llvm-readobj reports errors in ELF objects for some good examples.

Same goes for your other error messages.

================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:369
+                               " refers to invalid section with ESD id " +
+                               std::to_string(SymbEdId));
+}
----------------
Please ensure you build and test your code before uploading a patch - this will cause a build failure.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437