[PATCH] D101064: [WIP] improve debug-info in stack-slot-coloring

Markus Lavin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 22:45:05 PDT 2021


markus added a comment.

In D101064#2768775 <https://reviews.llvm.org/D101064#2768775>, @jmorse wrote:

> Sounds good to me, again there's a small risk that legitimate locations will be terminated when they shouldn't. But, we'll still be able to make an educated judgement about whether it's worth it.

Yes, may be a bit overconservative but should at least be correct. I gave it a go and then got sidetracked by other tasks. Seems it was not as easy as I originally thought as a SlotIndex does not always map to an instruction (or something like that IIRC). Will try to pick it up again in a not too distant future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101064/new/

https://reviews.llvm.org/D101064



More information about the llvm-commits mailing list