[PATCH] D102825: [llvm-strip] Add support for '--' for delimiting options from input files

[Sergey Dmitriev via Phabricator via llvm-commits]

sdmitriev created this revision.
sdmitriev added a reviewer: jhenderson.
Herald added a reviewer: alexshap.
Herald added a reviewer: rupprecht.
sdmitriev requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

This will allow to use llvm-strip with file names that begin with dashes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102825

Files:
  llvm/test/tools/llvm-objcopy/dash-dash.test
  llvm/test/tools/llvm-objcopy/tool-help-message.test
  llvm/tools/llvm-objcopy/CopyConfig.cpp


Index: llvm/tools/llvm-objcopy/CopyConfig.cpp
===================================================================
--- llvm/tools/llvm-objcopy/CopyConfig.cpp
+++ llvm/tools/llvm-objcopy/CopyConfig.cpp
@@ -1048,14 +1048,21 @@
 // help flag is set then ParseStripOptions will print the help messege and
 // exit.
 Expected<DriverConfig>
-parseStripOptions(ArrayRef<const char *> ArgsArr,
+parseStripOptions(ArrayRef<const char *> RawArgsArr,
                   llvm::function_ref<Error(Error)> ErrorCallback) {
+  const char *const *DashDash =
+      std::find_if(RawArgsArr.begin(), RawArgsArr.end(),
+                   [](StringRef Str) { return Str == "--"; });
+  ArrayRef<const char *> ArgsArr = makeArrayRef(RawArgsArr.begin(), DashDash);
+  if (DashDash != RawArgsArr.end())
+    DashDash = std::next(DashDash);
+
   StripOptTable T;
   unsigned MissingArgumentIndex, MissingArgumentCount;
   llvm::opt::InputArgList InputArgs =
       T.ParseArgs(ArgsArr, MissingArgumentIndex, MissingArgumentCount);
 
-  if (InputArgs.size() == 0) {
+  if (InputArgs.size() == 0 && DashDash == RawArgsArr.end()) {
     printHelp(T, errs(), ToolType::Strip);
     exit(1);
   }
@@ -1077,6 +1084,7 @@
                              Arg->getAsString(InputArgs).c_str());
   for (auto Arg : InputArgs.filtered(STRIP_INPUT))
     Positional.push_back(Arg->getValue());
+  std::copy(DashDash, RawArgsArr.end(), std::back_inserter(Positional));
 
   if (Positional.empty())
     return createStringError(errc::invalid_argument, "no input file specified");
Index: llvm/test/tools/llvm-objcopy/tool-help-message.test
===================================================================
--- llvm/test/tools/llvm-objcopy/tool-help-message.test
+++ llvm/test/tools/llvm-objcopy/tool-help-message.test
@@ -9,6 +9,7 @@
 # RUN: llvm-strip -h | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines
 # RUN: llvm-strip --help | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines
 # RUN: not llvm-strip 2>&1 | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines
+# RUN: not llvm-strip -- 2>&1 | FileCheck --check-prefix=STRIP-USAGE %s --match-full-lines
 # RUN: not llvm-strip -abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
 # RUN: not llvm-strip --abcabc 2>&1 | FileCheck --check-prefix=UNKNOWN-ARG %s
 # RUN: not llvm-strip --strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES
Index: llvm/test/tools/llvm-objcopy/dash-dash.test
===================================================================
--- llvm/test/tools/llvm-objcopy/dash-dash.test
+++ llvm/test/tools/llvm-objcopy/dash-dash.test
@@ -14,9 +14,26 @@
 # RUN: cmp -- out-obj2 --add-section
 
 ## Check the case when '--' is specified with options but no input files.
-# RUN: not llvm-objcopy --only-section=.test -- 2>&1 | FileCheck %s --check-prefixes=CHECK-NO-INPUT
+# RUN: not llvm-objcopy --only-section=.test -- 2>&1 | FileCheck %s --check-prefixes=CHECK-OBJCOPY-NO-INPUT
 
-# CHECK-NO-INPUT: error: no input file specified
+# CHECK-OBJCOPY-NO-INPUT: error: no input file specified
+
+## Check that llvm-strip correctly treats paths after '--' as file paths,
+## even if they start with dashes.
+# RUN: yaml2obj %s -o --strip-symbol
+# RUN: llvm-strip --remove-section=.test -o out-strip-obj1 -- --strip-symbol
+# RUN: llvm-strip --remove-section=.test -o out-strip-obj2 test-obj
+# RUN: cmp out-strip-obj1 out-strip-obj2
+
+## Check the case when '--' is specified with input files but no options.
+# RUN: llvm-strip -- --strip-symbol
+# RUN: llvm-strip -o out-strip-obj3 test-obj
+# RUN: cmp -- out-strip-obj3 --strip-symbol
+
+## Check the case when '--' is specified with options but no input files.
+# RUN: not llvm-strip --remove-section=.test -- 2>&1 | FileCheck %s --check-prefixes=CHECK-STRIP-NO-INPUT
+
+# CHECK-STRIP-NO-INPUT: error: no input file specified
 
 --- !ELF
 FileHeader:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102825.346628.patch
Type: text/x-patch
Size: 3870 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210520/6d46331d/attachment.bin>