[PATCH] D102803: [Verifier] Remove some redundant checks

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:5146-5149
+      if (FailureOrdering == AtomicOrdering::NotAtomic ||
+          FailureOrdering == AtomicOrdering::Unordered)
+        return error("Invalid record");
+
----------------
dblaikie wrote:
> Does this have test coverage?
no, it's the thing mentioned in the description

adding test coverage would require a bitcode file that was generated by a modified LLVM that allows this to bypass the LLParser/verifier

so this probably isn't an issue in practice since it's always been invalid, so there shouldn't be any bitcode out there that hits this
I guess I could just remove this check


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102803/new/

https://reviews.llvm.org/D102803