[PATCH] D102754: [unittests][CodeGen] Mark tests that cannot be executed with GTEST_SKIP()

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 19 17:48:59 PDT 2021


ikudrin added a comment.

In D102754#2769054 <https://reviews.llvm.org/D102754#2769054>, @scott.linder wrote:

> I see `// TODO: Use GTEST_SKIP() when GTest is updated to version 1.10.0` show up in `llvm/unittests/CodeGen/DIEHashTest.cpp`, `llvm/unittests/ExecutionEngine/Orc/OrcCAPITest.cpp` and `clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp`; would you consider updating those at the same time?

This patch is for `llvm/unittests/CodeGen`. There are D102710 <https://reviews.llvm.org/D102710> for `llvm/unittests/ExecutionEngine` and D102643 <https://reviews.llvm.org/D102643> for `clang/unittests/StaticAnalyzer` by their corresponding authors.

> Other than that this LGTM, thank you!

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102754/new/

https://reviews.llvm.org/D102754



More information about the llvm-commits mailing list