[PATCH] D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths
Jon Roelofs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 19 17:44:39 PDT 2021
jroelofs added a comment.
In D102452#2769992 <https://reviews.llvm.org/D102452#2769992>, @vvereschaka wrote:
> Hi @jroelofs,
>
> we've started getting the warnings for newly created file `llvm/lib/Transforms/Utils/MemoryOpRemark.cpp` on the cross toolchain builders:
>
> c:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\transforms\utils\memoryopremark.cpp(123) : warning C4715: 'llvm::MemoryOpRemark::remarkName': not all control paths return a value
> c:\buildbot\as-builder-2\x-aarch64\llvm-project\llvm\lib\transforms\utils\memoryopremark.cpp(381) : warning C4715: 'llvm::AutoInitRemark::remarkName': not all control paths return a value
>
> one of the builds as example: https://lab.llvm.org/buildbot/#/builders/119/builds/3889
>
> there is no return for the method's argument unknown value.
>
> Would you take care of it?
Sure! This ought to silence it: 3d2ffc88e6afa027369ce100779dacb1c35c6a51 <https://reviews.llvm.org/rG3d2ffc88e6afa027369ce100779dacb1c35c6a51>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102452/new/
https://reviews.llvm.org/D102452
More information about the llvm-commits
mailing list